Update butter zero phase with composition of standard forward and a new backward filter#124
Merged
Update butter zero phase with composition of standard forward and a new backward filter#124
Conversation
… forward and a backward filter that operates on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ButterworthFilterTransformerfollowed by a newButterworthBackwardFilterTransformerthat buffers and applies the filter in reverse, making the zero-phase filter fully streaming-compatiblesettle_cutoffandmax_pad_durationsettings that compute pad length from the filter's actual impulse response settling time, replacing the old padtype/padlen parameters which relied on scipy's order-based heuristic (inadequate for filters with very low normalized frequencies, e.g. a 30 Hz lowpass at 30 kHz needs 2,292 samples to settle but scipy's heuristic gives only 15)